[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.6 5/8] tools/libxl: Save and restore EMULATOR_XENSTORE_DATA content

On 31/07/15 17:34, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [PATCH for-4.6 5/8] tools/libxl: Save and restore 
>> On 29/07/15 12:49, Ian Jackson wrote:
>>>> +    rel_start = strlen(xs_path) - 7;
>>> This is horrible.
>> What do you recommend instead?
> I don't see why it is necessary to do something like rel_start at all.
> This whole patch could probably be made much simpler with something
> like
>    static const char *const physmap_entries[] = {
>        "start_addr", "size", "name", NULL
>    };
> and then loop over it a few times.

But the rel_path has nothing to do with which subkeys get chosen.

It is to strip out the current domains information from

This is because both of the domid in the path will be different on the
other side of migration.  This is why EMULATOR_XENSTORE_DATA is
purposefully specified relative to the above path, rather than as
absolute paths.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.