[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2] x86, amd_ucode: Skip microcode updates for final levels

On 8/3/2015 2:00 PM, Boris Ostrovsky wrote:
On 08/03/2015 02:42 PM, Aravind Gopalakrishnan wrote:

Ah. I see what you mean.
I can think of two ways around this-
a. I can move the check_final_patch_levels() call to apply_microcode(). That way, our initial checks in microcode_fits() would have already checked equivalent cpu IDs so we know we are on the right family. b. Introduce a family check in this patch as you suggested (It's a simple change, should work fine too and I think can retain Andrew's 'Reviewed-by' as the logic doesn't change too much..)

Do let me know if you have a preference.

I'd leave it where it is right now since there is no reason to do all allocations/checks/stuff and then get to apply_microcode() and find out that it was all for nothing. So just testing boot_cpu_data.x86 in check_final_patch_levels() and returning if it's not 10h should be sufficient.

Okay, will do it this way and resend.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.