[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.6 v2 1/6] tools/libxl: Make libxl__conversion_helper_abort() safe to use

On Mon, 2015-08-03 at 16:56 +0100, Andrew Cooper wrote:
> Previously, in the case of an error causing a call to
> libxl__conversion_helper_abort() on a stream without legacy conversion,
> libxl would fall over a NULL pointer because chs->ao was not set up.
> Arrange for all ->ao's to be set up at _init() time, by having each
> _init() function assert that their caller has done the right thing.
> While doing so, introduce a previously-missing save_helper_init() in
> stream_read_init().
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> v2: Make sure ->ao is always valid

I believe this + the extra comment in libxl__conversion_helper_state
addresses Ian J's feedback from the previous round, so:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.