[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.6 v2] x86/mm: Make {hap, shadow}_teardown() preemptible

On Wed, Aug 05, 2015 at 04:47:59PM +0100, Andrew Cooper wrote:
> From: Anshul Makkar <anshul.makkar@xxxxxxxxxx>
> A domain with sufficient shadow allocation can cause a watchdog timeout
> during domain destruction.  Expand the existing -ERESTART logic in
> paging_teardown() to allow {hap/sh}_set_allocation() to become
> restartable during the DOMCTL_destroydomain hypercall.
> Signed-off-by: Anshul Makkar <anshul.makkar@xxxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Tim Deegan <tim@xxxxxxx>
> ---
> CC: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> v2:
>  * Drop {HAP,SHADOW}_PRINTK().  They are not very useful, and will get
>    very noisy if enabled.
> Wei: Currently, Xen can't actually run 1TB guests without suffering a
> watchdog timeout when destroying the domain.  Therefore this is fairly
> important for 4.6 (and backport), or we will have to retroactively drop
> the currently-stated supported limits on the wiki.

Right. This is a good reason to have it for 4.6.

Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.