Re: [Xen-devel] [PATCH v4 24/31] libxc: allow creating domains without emulated devices.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Aug 07, 2015 at 12:18:01PM +0200, Roger Pau Monne wrote:
> Introduce a new flag in xc_dom_image that turns on and off the emulated
> devices. This prevents creating the VGA hole, the hvm_info page and the
> ioreq server pages. libxl unconditionally sets it to true for all HVM
> domains at the moment.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Changes since v3:
>  - Explain the meaning of the "emulation" xc_dom_image field.
> ---
>  tools/libxc/include/xc_dom.h |  3 ++
>  tools/libxc/xc_dom_x86.c     | 71 
> +++++++++++++++++++++++++-------------------
>  tools/libxl/libxl_dom.c      |  1 +
>  3 files changed, 44 insertions(+), 31 deletions(-)
> 
> diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/include/xc_dom.h
> index cda40d9..99225cf 100644
> --- a/tools/libxc/include/xc_dom.h
> +++ b/tools/libxc/include/xc_dom.h
> @@ -194,6 +194,9 @@ struct xc_dom_image {
>      xen_pfn_t lowmem_end;
>      xen_pfn_t highmem_end;
>  
> +    /* If set disables the setup of the IOREQ pages and the VGA MMIO hole. */
> +    bool emulation;
> +

My impression is that we might want to enable / disable specific
emulation functionalities in the future, but since this is internal
detail so we have the liberty to do whatever we want.

A single flag and a comment here is good enough for me. The code also
looks correct. So

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel