Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test each new baseline

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test 
each new baseline"):
> I also considered refactoring this bit:
> 
>               if [ "x$treeurl" != xnone: ]; then
>                       treearg=--tree-$tree=$treeurl
>               fi
>               tested_revision=`check_tested $treearg --print-revision=$tree`
>               if [ "x$tested_revision" != x ]; then
>                       OLD_REVISION="$tested_revision"
>               fi
> 
> into a helper e.g. select_last_test_revision.

That might be best as it gives it a name.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel