[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v2 2/2] ACPI: disable ACPI cleanly when bad RSDP found

From: Len Brown <len.brown@xxxxxxxxx>

Ported from Linux commit 9e3a9d1ed8cc8db93e5c53e9a5b09065bd95de8b.

When ACPI is disabled in the BIOS of this VIA C3 box,
it invalidates the RSDP, which Linux notices:

ACPI Error (tbxfroot-0218): A valid RSDP was not found [20080926]

Bug Linux neglected to disable ACPI at that stage,
and later scribbled on smp_found_config:

ACPI: No APIC-table, disabling MPS

But this box doesn't run well in legacy PIC mode,
it needed IOAPIC mode to perform correctly:


So exit ACPI mode cleanly when we first detect
that it is hopeless.

Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
 xen/drivers/acpi/tables.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c
index 1da2127..6085fda 100644
--- a/xen/drivers/acpi/tables.c
+++ b/xen/drivers/acpi/tables.c
@@ -329,7 +329,12 @@ static void __init check_multiple_madt(void)
 int __init acpi_table_init(void)
-       acpi_initialize_tables(NULL, ACPI_MAX_TABLES, 0);
+       acpi_status status;
+       status = acpi_initialize_tables(NULL, ACPI_MAX_TABLES, 0);
+       if (ACPI_FAILURE(status))
+               return 1;
        return 0;

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.