Re: [Xen-devel] [PATCH for-4.6] xl/vNUMA: Allow empty memory nodes

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 08/14/2015 12:26 PM, Wei Liu wrote:
> This title should say "libxc: ..."
Ah, of course. Let me know if you want me to re-send it.

-boris

> On Fri, Aug 14, 2015 at 12:18:52PM -0400, Boris Ostrovsky wrote:
> > The test for 'nr_vmemranges < nr_vnodes' in xc_domain_setvnuma() was
> > originally writtten with the idea that number of memory ranges would
> > at least be equal to number of nodes.
> >
> > We may want to specify nodes with no memory, however, and thus this
> > check should be removed.
> >
> > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>
> With my RM hat on, because libxl, hypervisor and hvmloader can already
> cope with 0 vmemrange configuration, removing this restriction is safe.
>
> Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>
> > ---
> >   tools/libxc/xc_domain.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
> > index 2ee26fb..780797f 100644
> > --- a/tools/libxc/xc_domain.c
> > +++ b/tools/libxc/xc_domain.c
> > @@ -2451,8 +2451,7 @@ int xc_domain_setvnuma(xc_interface *xch,
> >                                XC_HYPERCALL_BUFFER_BOUNCE_BOTH);
> >       errno = EINVAL;
> >   
> > -    if ( nr_vnodes == 0 || nr_vmemranges == 0 ||
> > -         nr_vmemranges < nr_vnodes || nr_vcpus == 0 )
> > +    if ( nr_vnodes == 0 || nr_vmemranges == 0 || nr_vcpus == 0 )
> >           return -1;
> >   
> >       if ( !vdistance || !vcpu_to_vnode || !vmemrange || !vnode_to_pnode )
> > --
> > 1.9.3

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel