Re: [Xen-devel] [PATCH v10 08/11] xen: arch-specific hooks for domain_soft_reset()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.07.15 at 15:28, <vkuznets@xxxxxxxxxx> wrote:
> x86-specific hook cleans up the pirq-emuirq mappings, destroys all ioreq
> servers and and replaces the shared_info frame with an empty page to support
> subsequent XENMAPSPACE_shared_info call.
> 
> ARM-specific hook is -ENOSYS for now.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with one minor remark:

> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -1066,6 +1066,13 @@ int domain_soft_reset(struct domain *d)
>      for_each_vcpu ( d, v )
>          unmap_vcpu_info(v);
>  
> +    rc = arch_domain_soft_reset(d);
> +    if ( rc )
> +    {
> +        domain_crash(d);
> +        return rc;
> +    }
> +
>      domain_resume(d);
>  
>      return 0;

Perhaps better written as

    rc = arch_domain_soft_reset(d);
    if ( !rc )
        domain_resume(d);
    else
        domain_crash(d);

    return rc;

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel