[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 24/31] libxc: allow creating domains without emulated devices.

On 17/08/15 08:55, Roger Pau Monnà wrote:
El 07/08/15 a les 18.36, Andrew Cooper ha escrit:
On 07/08/15 11:18, Roger Pau Monne wrote:
@@ -1336,7 +1343,8 @@ static int meminit_hvm(struct xc_dom_image *dom)
           * tot_pages will be target_pages - VGA_HOLE_SIZE after
           * this call.
-        rc = xc_domain_set_pod_target(xch, domid, target_pages - VGA_HOLE_SIZE,
+        rc = xc_domain_set_pod_target(xch, domid, target_pages -
+                                      dom->emulation ? VGA_HOLE_SIZE : 0,
                                        NULL, NULL, NULL);
This might be more cleanly expressed as having d->vga_hole_size which is
either VGA_HOLE_SIZE or 0, depending on dom->emulation.
I'm afraid I don't understand this comment. What's "d" in the phrase
above? I cannot see any local variable or argument called "d" in the
context of meminit_hvm.

I meant introducing a new variable, dom->vga_hole_size, which gets set to 0 or VGA_HOLE_SIZE earlier on.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.