Re: [Xen-devel] [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()

[Murilo Opsfelder AraÃjo <mopsfelder@xxxxxxxxx>]

On Wed, Aug 19, 2015 at 9:23 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hi,
>
> On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote:
>>
>> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
>> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
>> xen_tmem_get_page() receiving pfn instead of page.
>>
>> This change also fixes the following build warning:
>>
>> drivers/xen/tmem.c: In function âtmem_cleancache_get_pageâ:
>> drivers/xen/tmem.c:194:47: warning: passing argument 4 of
>> âxen_tmem_get_pageâ makes pointer from integer without a cast
>>    ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
>>                                                 ^
>> drivers/xen/tmem.c:138:12: note: expected âstruct page *â but argument is
>> of type âlong unsigned intâ
>>   static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
>>              ^
>>
>> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@xxxxxxxxx>
>
>
> Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is not
> enabled on my config.
>
> Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>
>
> Regards,
>
> --
> Julien Grall

Hi, Julien.

No need to apologize, and thanks for reviewing that.

-- 
Murilo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel