Re: [Xen-devel] [PATCH] x86/vmx: fix vmx_is_singlestep_supported return value

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

>> @@ -1768,7 +1768,7 @@ static void vmx_enable_msr_exit_interception(struct 
>> domain *d)
>>
>>  static bool_t vmx_is_singlestep_supported(void)
>>  {
>> -    return cpu_has_monitor_trap_flag;
>> +    return cpu_has_monitor_trap_flag ? 1 : 0;
>
> Prevailing style would tend towards !!cpu_has_monitor_trap_flag

Yeap, you are right. If the maintainers prefer I can resend with that style.

>
> Either way, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks!
Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel