Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Aug 27, 2015 at 07:02:00AM -0400, Konrad Rzeszutek Wilk wrote:
> The operations are to be used by an control domain to set parameters,
> list pools, clients, and to be used during migration.
> 
> There is no need to have them in the tmem hypercall path.
> 
> This patch moves code without adding fixes - and in fact in
> some cases makes the parameters soo long that they hurt eyes - but
> that is for another patch.
> 
> Note that in regards to existing users:
> 
>  - Only the control domain could call it - which meant that if
>    a guest called it would get -EPERM, so we are OK there.
>    In practice no guests called this TMEM_CONTROL command.
> 
>  - The spec: 
> https://oss.oracle.com/projects/tmem/dist/documentation/api/tmemspec-v001.pdf
>    mentions: "TBD [Not sure if this is really needed.]"
>    which is a carte blanche as any to do this!
> 
> Note: The XSM check is the same - we just move it from do_tmem_op
> to do_sysctl.
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Toolstack changes look mechanical:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel