[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

> On Aug 27, 2015, at 10:27 AM, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> On 27/08/15 15:47, Jonathan Creekmore wrote:
>> Add the appropriate #if checks around the kexec code in the x86 codebase
>> so that the feature can actually be turned off by the flag instead of
>> always required to be enabled on x86.
> What's your use case for this?

The use case is for a slimmed down version of the hypervisor that can be used 
as a security hypervisor, exposing as little extra functionality as possible. 
When looking for features to trim out to reduce the attack surface, I saw the 
flag for KEXEC and wanted to disable that, then ran into compile problems.

> I think you should consider providing empty stub functions for !KEXEC
> instead of all the #ifdefs.

Good points, all, who mentioned the empty stub functions. I am revising it now 
to use stubs instead of all of the #ifdefs.

>> --- a/xen/include/asm-x86/config.h
>> +++ b/xen/include/asm-x86/config.h
>> @@ -1,6 +1,6 @@
>> /******************************************************************************
>>  * config.h
>> - * 
>> + *
>>  * A Linux-style configuration list.
>>  */
> Stray whitespace change.

I guess I really need to just turn off that feature (stripping trailing 
whitespace) in my editor. So useful when writing new code, not as helpful when 
trying to modify existing code.
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.