Re: [Xen-devel] [PATCH] x86: adjustments to memory_add()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/08/15 15:29, Jan Beulich wrote:
>>>> On 28.08.15 at 16:11, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 28/08/15 14:54, Jan Beulich wrote:
>>> The function should clean up after a failed map_pages_to_xen().
>>>
>>> Sharing the M2P table with Dom0 needs to happen before adding
>>> the new pages to the heap.
>> Why? Does this not create a race where dom0 can observe the new mfns
>> before they are ready to use?
> No, observing the MFNs is fine as long as no domain can use them.
> The race is the other way around: Not having the M2P in place
> when the pages could already be handed out from the allocator is
> a problem.

Ah yes - of course.  Would you mind extending the patch description to
include this.

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel