Re: [Xen-devel] [PATCH v8 2/3] Differentiate IO/mem resources tracked by ioreq server

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-08-25 at 10:40 +0100, Wei Liu wrote:
> On Sun, Aug 23, 2015 at 05:33:17PM +0800, Yu Zhang wrote:
> > Currently in ioreq server, guest write-protected ram pages are
> > tracked in the same rangeset with device mmio resources. Yet
> > unlike device mmio, which can be in big chunks, the guest write-
> > protected pages may be discrete ranges with 4K bytes each. This
> > patch uses a seperate rangeset for the guest ram pages.
> > 
> > Note: Previously, a new hypercall or subop was suggested to map
> > write-protected pages into ioreq server. However, it turned out
> > handler of this new hypercall would be almost the same with the
> > existing pair - HVMOP_[un]map_io_range_to_ioreq_server, and there's
> > already a type parameter in this hypercall. So no new hypercall
> > defined, only a new type is introduced.
> > 
> > Signed-off-by: Yu Zhang <yu.c.zhang@xxxxxxxxxxxxxxx>
> > ---
> >  tools/libxc/include/xenctrl.h    | 31 ++++++++++++++++++++
> >  tools/libxc/xc_domain.c          | 61 
> > ++++++++++++++++++++++++++++++++++++++++
> 
> For tools bits:
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

I looked at it before I saw this and as a binding for the hypercall it LGTM
as well:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

There appear to be no callers of these new interfaces, are those to come
later?

Given the trivial nature of the tools side here I'm likely not going to pay
much attention to this series from now on, please drop me an explicit ping
if something changes which requires my attention.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel