Re: [Xen-devel] [PATCH net-next] xen-netback: add support for multicast control

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> Sent: 02 September 2015 15:01
> To: Paul Durrant
> Cc: netdev@xxxxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxxx; Ian Campbell;
> Wei Liu
> Subject: Re: [PATCH net-next] xen-netback: add support for multicast control
> 
> On Wed, Sep 02, 2015 at 01:19:53PM +0100, Paul Durrant wrote:
> > Xen's PV network protocol includes messages to add/remove ethernet
> > multicast addresses to/from a filter list in the backend. This allows
> > the frontend to request the backend only forward multicast packets
> > which are off interest thus preventing unnecessary noise on the shared
> 
> "of interest"

Ah yes :-)

> 
> > ring.
> >
> [...]
> > +
> > +void xenvif_mcast_flush(struct xenvif *vif)
> 
> Only one cosmetic comment.
> 
> My first impression of this function by looking at the name is that it
> flushes queued multicast packets. Maybe we can rename it to
> xenvif_mcast_addr_list_free ?
> 

Sure.

  Paul

> Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel