Re: [Xen-devel] [PATCH v2 net-next] xen-netback: add support for multicast control

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 03 September 2015 09:57
> To: Paul Durrant
> Cc: Ian Campbell; Wei Liu; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH v2 net-next] xen-netback: add support for
> multicast control
> 
> >>> On 02.09.15 at 18:58, <paul.durrant@xxxxxxxxxx> wrote:
> > @@ -1215,6 +1289,31 @@ static void xenvif_tx_build_gops(struct
> xenvif_queue *queue,
> >                             break;
> >             }
> >
> > +           if (extras[XEN_NETIF_EXTRA_TYPE_MCAST_ADD - 1].type) {
> > +                   struct xen_netif_extra_info *extra;
> > +
> > +                   extra =
> &extras[XEN_NETIF_EXTRA_TYPE_MCAST_ADD - 1];
> > +                   ret = xenvif_mcast_add(queue->vif, extra-
> >u.mcast.addr);
> 
> What's the reason this call isn't gated on vif->multicast_control?
> 

No particular reason. I guess it eats a small amount of memory for no gain but 
a well behaved frontend wouldn't send such a request and a malicious one can 
only send 64 of them before netback starts to reject them.

  Paul

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel