Re: [Xen-devel] [PATCH for 4.6 2/5] libxc: migration v2 prefix Memory -> Memory (P2M)

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 04, 2015 at 09:40:55PM +0100, Andrew Cooper wrote:
> On 04/09/15 19:32, Wei Liu wrote:
> >The prefix "Memory" is confusing because the numbers shown after that
> >are referring to P2M entries. They have no bearing on how many pages a
> >domain actually owns or how many actual pages are processed.
> >
> >Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >---
> >  tools/libxc/xc_sr_save.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
> >index 58667af..bb7ff54 100644
> >--- a/tools/libxc/xc_sr_save.c
> >+++ b/tools/libxc/xc_sr_save.c
> >@@ -659,7 +659,7 @@ static int send_domain_memory_nonlive(struct 
> >xc_sr_context *ctx)
> >      if ( rc )
> >          goto err;
> >-    xc_set_progress_prefix(xch, "Memory");
> >+    xc_set_progress_prefix(xch, "Memory (P2M)");
> 
> This is incorrect for autotranslated guests.  I would recommend "Frames"
> instead.
> 

Fine by me of course.

Wei.

> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel