Re: [Xen-devel] [PATCH v6 08/18] vmx: Suppress posting interrupts when 'SN' is set

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.09.15 at 04:33, <feng.wu@xxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: Friday, September 04, 2015 10:53 PM
>> >>> On 25.08.15 at 03:57, <feng.wu@xxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/hvm/vmx/vmx.c
>> > +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> > @@ -1701,8 +1701,36 @@ static void vmx_deliver_posted_intr(struct vcpu
>> *v, u8 vector)
>> >           */
>> >          pi_set_on(&v->arch.hvm_vmx.pi_desc);
>> >      }
>> > -    else if ( !pi_test_and_set_on(&v->arch.hvm_vmx.pi_desc) )
>> > +    else
>> >      {
>> > +        struct pi_desc old, new, prev;
>> > +
>> > +        /* To skip over first check in the loop below. */
>> > +        prev.control = 0;
>> 
>> Why don't you just read the field instead of adding the comment?
> 
> What do you mean by "read the field"? Could you please elaborate it?

        prev.control = v->arch.hvm_vmx.pi_desc.control;

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel