Re: [Xen-devel] [PATCH v3 0/4] arm64: Add Xen boot support (via fdt)

[Fu Wei <fu.wei@xxxxxxxxxx>]

Hi Vladimir,

Do you have any suggestion on this patchset?
Do I need to improve anything?

Great thanks for your help.

On 4 August 2015 at 16:34, Fu Wei <fu.wei@xxxxxxxxxx> wrote:
> Hi Vladimir,
>
> this patchset follows all your comment of v2 patchset.
> Do you have any suggestion on this patchset?
>
> Great thanks for your help.
>
>
> On 23 July 2015 at 13:16,  <fu.wei@xxxxxxxxxx> wrote:
>> From: Fu Wei <fu.wei@xxxxxxxxxx>
>>
>>   - This adds support for the Xen boot on ARM specification for arm64.
>>
>>   - Add and export some accessor functions of "loaded" flag and
>>     grub_linux_get_fdt function in include/grub/arm64/linux.h for xen boot.
>>
>>   - Introduce xen_hypervisor, xen_linux, xen_initrd and xen_xsm
>>     to load different binaries for xen boot.
>>     Introduce xen_module to load common or custom module for xen boot.
>>
>>   - This Xen boot support is a separated  module for aarch64,
>>     but reuse the existing code of devicetree in linux module.
>>
>>   - Add the support of xen_hypervisor, xen_linux and xen_initrd
>>     in util/grub.d/20_linux_xen.in
>>
>>   - Add the introduction of all xen boot commands in docs/grub.texi
>>
>>   - The example of this support is <How to boot Xen with GRUB on AArch64 the 
>> Foundation FVP model>
>>     
>> https://wiki.linaro.org/LEG/Engineering/Grub2/Xen_booting_on_Foundation_FVP_model_by_GRUB
>>
>> Changelog:
>> v3: create separate module for xen boot: xen_boot
>>     create separate commands for different types of module
>>     delete order-dependent for commands of xen module
>>     simplify the code
>>
>> v2: remove the patches which have been accepted.
>>     according to Vladimir's suggestion, change the command manes
>>     and relevant code:
>>         multiboot-->xen_hypervisor
>>         module-->xen_module
>>     improve the option parsing support for xen_hypervisor/xen_module 
>> commands.
>>     add a patch for adding xen_hypervisor/xen_module support
>>     in util/grub.d/20_linux_xen.in.
>>     update docs/grub.texi patch for the new command names.
>>
>> v1: The first version upstream patchset to grub-devel mailing list
>>
>>
>> Fu Wei (4):
>>   arm64: Add and export some accessor functions for xen boot
>>   arm64: Add xen_boot module file
>>   * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64
>>   arm64: Add the introduction of xen boot commands in docs/grub.texi
>>
>>  docs/grub.texi                    |  56 ++++
>>  grub-core/Makefile.core.def       |   7 +
>>  grub-core/loader/arm64/linux.c    |  13 +
>>  grub-core/loader/arm64/xen_boot.c | 685 
>> ++++++++++++++++++++++++++++++++++++++
>>  include/grub/arm64/linux.h        |   6 +-
>>  util/grub.d/20_linux_xen.in       |  16 +-
>>  6 files changed, 779 insertions(+), 4 deletions(-)
>>  create mode 100644 grub-core/loader/arm64/xen_boot.c
>>
>> --
>> 1.8.3.1
>>
>
>
>
> --
> Best regards,
>
> Fu Wei
> Software Engineer
> Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
> Ph: +86 21 61221326(direct)
> Ph: +86 186 2020 4684 (mobile)
> Room 1512, Regus One Corporate Avenue,Level 15,
> One Corporate Avenue,222 Hubin Road,Huangpu District,
> Shanghai,China 200021



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel