Re: [Xen-devel] [PATCH v2] efi: introduce efi_arch_flush_dcache_area

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Stefano,

On 08/09/15 11:38, Stefano Stabellini wrote:
> Objects loaded by FileHandle->Read need to be flushed from dcache,
> otherwise copy_from_paddr will read stale data when copying the kernel,
> causing a failure to boot.

It would have been nice to have some explanation why we can read stale
data in the commit message (see [1]).

It would avoid to look at the ML in the future to understand why this
patch is here.

> Introduce efi_arch_flush_dcache_area and call it from read_file.
> 
> This commit introduces no functional changes on x86.

[1] http://www.gossamer-threads.com/lists/xen/devel/396892#396892

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel