[Xen-devel] [PATCH v2] Remove XenPTReg->data and use dev.config for guest configuration values.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

Hey!

Since v1: (http://lists.xen.org/archives/html/xen-devel/2015-07/msg00442.html)
 - Acked on review.
RFC [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07350.html]
 - Added Acks
 - Fixed bugs

This patchset is dependent on the "Cleanups + various fixes due to libxl ABI
more logging on errors" which is located at 
git://xenbits.xen.org/people/konradwilk/qemu.git 
v2-cleanups-fixes-due-to-libxlABI
(or http://lists.xen.org/archives/html/xen-devel/2015-09/msg00935.html)

The status of the patches is as follow:

 R xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config
 R xen/pt: Sync up the dev.config and data values.
   xen/pt: Check if reg->init function sets the 'data' past the reg->size
   xen/pt: Remove XenPTReg->data field.
 A xen/pt: Log xen_host_pci_get in two init functions
 R xen/pt: Log xen_host_pci_get/set errors in MSI code.
 R xen/pt: Make xen_pt_unregister_device idempotent
 A xen/pt: Move bulk of xen_pt_unregister_device in its own routine.
 A xen/pt: Check for return values for xen_host_pci_[get|set] in init
 R xen/pt: Don't slurp wholesale the PCI configuration registers

Where 'A' - Acked-by, 'R' - Reviewed-by.

The two patches:
 [PATCH v2 03/10] xen/pt: Check if reg->init function sets the 'data' past the 
reg->size

Stefano asked me to make this a build time check but I could not figure
out how. See http://lists.xen.org/archives/html/xen-devel/2015-08/msg01547.html 
for details.

 [PATCH v2 04/10] xen/pt: Remove XenPTReg->data field.

Stefano asked me to s/word/half-word/g s/dbword/word/ - which this does.

Please review.

The patches are also available at:
From Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> # This line is ignored.
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: [PATCH v2]  Remove XenPTReg->data and use dev.config for guest 
configuration values.
In-Reply-To: 

Hey!

Since v1: (http://lists.xen.org/archives/html/xen-devel/2015-07/msg00442.html)
 - Acked on review.
RFC [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07350.html]
 - Added Acks
 - Fixed bugs

This patchset is dependent on the "Cleanups + various fixes due to libxl ABI
more logging on errors" which is located at 
git://xenbits.xen.org/people/konradwilk/qemu.git 
v2-cleanups-fixes-due-to-libxlABI
(or http://lists.xen.org/archives/html/xen-devel/2015-09/msg00935.html)

The status of the patches is as follow:

 R xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config
 R xen/pt: Sync up the dev.config and data values.
   xen/pt: Check if reg->init function sets the 'data' past the reg->size
   xen/pt: Remove XenPTReg->data field.
 A xen/pt: Log xen_host_pci_get in two init functions
 R xen/pt: Log xen_host_pci_get/set errors in MSI code.
 R xen/pt: Make xen_pt_unregister_device idempotent
 A xen/pt: Move bulk of xen_pt_unregister_device in its own routine.
 A xen/pt: Check for return values for xen_host_pci_[get|set] in init
 R xen/pt: Don't slurp wholesale the PCI configuration registers

Where 'A' - Acked-by, 'R' - Reviewed-by.

The two patches:
 [PATCH v2 03/10] xen/pt: Check if reg->init function sets the 'data' past the 
reg->size

Stefano asked me to make this a build time check but I could not figure
out how. See http://lists.xen.org/archives/html/xen-devel/2015-08/msg01547.html 
for details.

 [PATCH v2 04/10] xen/pt: Remove XenPTReg->data field.

Stefano asked me to s/word/half-word/g s/dbword/word/ - which this does.

Please review.

The patches are also available at:

 git://xenbits.xen.org/people/konradwilk/qemu.git postxsa120.v2

Thank you!


 hw/xen/xen-host-pci-device.c |   5 +
 hw/xen/xen-host-pci-device.h |   1 +
 hw/xen/xen_pt.c              | 152 +++++++++++++++++------------
 hw/xen/xen_pt.h              |   8 +-
 hw/xen/xen_pt_config_init.c  | 222 ++++++++++++++++++++++++++++++++-----------
 hw/xen/xen_pt_msi.c          |  18 +++-
 6 files changed, 288 insertions(+), 118 deletions(-)

Konrad Rzeszutek Wilk (10):
      xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config
      xen/pt: Sync up the dev.config and data values.
      xen/pt: Check if reg->init function sets the 'data' past the reg->size
      xen/pt: Remove XenPTReg->data field.
      xen/pt: Log xen_host_pci_get in two init functions
      xen/pt: Log xen_host_pci_get/set errors in MSI code.
      xen/pt: Make xen_pt_unregister_device idempotent
      xen/pt: Move bulk of xen_pt_unregister_device in its own routine.
      xen/pt: Check for return values for xen_host_pci_[get|set] in init
      xen/pt: Don't slurp wholesale the PCI configuration registers

 git://xenbits.xen.org/people/konradwilk/qemu.git postxsa120.v2

Thank you!


 hw/xen/xen-host-pci-device.c |   5 +
 hw/xen/xen-host-pci-device.h |   1 +
 hw/xen/xen_pt.c              | 152 +++++++++++++++++------------
 hw/xen/xen_pt.h              |   8 +-
 hw/xen/xen_pt_config_init.c  | 222 ++++++++++++++++++++++++++++++++-----------
 hw/xen/xen_pt_msi.c          |  18 +++-
 6 files changed, 288 insertions(+), 118 deletions(-)

Konrad Rzeszutek Wilk (10):
      xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config
      xen/pt: Sync up the dev.config and data values.
      xen/pt: Check if reg->init function sets the 'data' past the reg->size
      xen/pt: Remove XenPTReg->data field.
      xen/pt: Log xen_host_pci_get in two init functions
      xen/pt: Log xen_host_pci_get/set errors in MSI code.
      xen/pt: Make xen_pt_unregister_device idempotent
      xen/pt: Move bulk of xen_pt_unregister_device in its own routine.
      xen/pt: Check for return values for xen_host_pci_[get|set] in init
      xen/pt: Don't slurp wholesale the PCI configuration registers


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel