[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v6 08/31] xen/arm: ITS: Introduce msi_desc for LPIs
On 09/09/15 14:16, Ian Campbell wrote: > On Mon, 2015-08-31 at 16:36 +0530, vijay.kilari@xxxxxxxxx wrote: >> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx> >> >> Define msi_desc structure for arm and introduce >> helper functions to access msi_desc member variables. >> >> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx> >> --- >> xen/arch/arm/gic-v3-its.c | 28 ++++++++++++++++++++++++++++ >> xen/arch/arm/irq.c | 12 ++++++++++++ >> xen/include/asm-arm/gic-its.h | 4 ++++ >> xen/include/asm-arm/irq.h | 9 +++++++++ >> 4 files changed, 53 insertions(+) >> >> diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c >> index 88cc89d..e70c21a 100644 >> --- a/xen/arch/arm/gic-v3-its.c >> +++ b/xen/arch/arm/gic-v3-its.c >> @@ -109,6 +109,34 @@ static void dump_cmd(const its_cmd_block *cmd) >> static void dump_cmd(const its_cmd_block *cmd) { } >> #endif >> >> +void irqdesc_set_lpi_event(struct irq_desc *desc, unsigned id) > > LPIs are logically part of the GIC, not the ITS, so I think all four of > these belong at least in a gic (without -its) .c file if not in irq.c. > > Or is there a reason for them to live here? Putting those helpers in irq.c will require some #ifdery in order to not compile when GICV3 is not built. I'd like to avoid any #ifdef in the common code for ITS specific code (see irqdesc_set_its_device). Although, as I said in a previous mail, those helpers are pointless as they are only used a couple of time and always in a batch. So we should result to fetch MSI everytime we'd like to access a field. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |