[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [BUG] xenctrl.h : error with xc_error_code declaration


  • To: SÃbastien FrÃmal <sebastien.fremal@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Thu, 10 Sep 2015 15:59:03 +0300
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Thu, 10 Sep 2015 12:59:13 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=oYmNVO8pQxAYjZCC/+M8ycTqVYtS17icNaNgmTG/nqEW/4hF2xPM6HiOWoVrK9zri4KQVMQvb2BltMRMAmz2o09WGx/5wNazEKutHdLYvQeepdrNwy3Ma87P8X28QgGco4p+i2rEBHwcoi4kyEjdvGSmvzVpWXQnLhkxDA+6gFAUFkWmDjG+Nbg4UqvtKINIMBHaNiP2WOkWxKnyqOzbXI748k1JDdMvz7yYpOwxjltP3c8ewqhi0P9KXvbw+lB4GLGvW/pOCrG8VFwy4G3ybdSVTa5HblGrLw/HTk5Yy+R6CBx+eGpL+g2VosxAZK+PYI/oJij0nLXNm74FIXbTyQ==; h=Received:Received:Received:Received:Received:Subject:To:References:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 09/10/2015 03:52 PM, Sébastien Frémal wrote:
> I just write to signal a bug and its solution. I installed the 14.04 LTS
> ubuntu version and installed the xen version through synaptic. As I'm
> developping modules for Xen I also installed the xen dev package. The
> installed Xen version is 4.4.2.
> 
> I tried to compile one of my C files including xenctrl.h but I got the
> following errors :
> In file included from ../modules/gntring/libgntring4.c:12:0:
> /usr/include/xenctrl.h:122:14: error: use of enum ‘xc_error_code’
> without previous declaration
>  typedef enum xc_error_code xc_error_code;
>               ^
> /usr/include/xenctrl.h:122:41: error: invalid type in declaration before
> ‘;’ token
>  typedef enum xc_error_code xc_error_code;
>                                          ^
> /usr/include/xenctrl.h:1759:6: error: using typedef-name ‘xc_error_code’
> after ‘enum’
>  enum xc_error_code {
>       ^
> /usr/include/xenctrl.h:122:28: note: ‘xc_error_code’ has a previous
> declaration here
>  typedef enum xc_error_code xc_error_code;
>                             ^
> /usr/include/xenctrl.h:1770:8: error: using typedef-name ‘xc_error_code’
> after ‘enum’
>    enum xc_error_code code;
>         ^
> /usr/include/xenctrl.h:122:28: note: ‘xc_error_code’ has a previous
> declaration here
>  typedef enum xc_error_code xc_error_code;
> 
> 
> 
> 
> I looked at xenctrl.h and the typedef is put before the declaration of
> the enum :
> 
> typedef enum xc_error_code xc_error_code;
> 
> ...
> 
> enum xc_error_code {
>   XC_ERROR_NONE = 0,
>   XC_INTERNAL_ERROR = 1,
>   XC_INVALID_KERNEL = 2,
>   XC_INVALID_PARAM = 3,
>   XC_OUT_OF_MEMORY = 4,
>   /* new codes need to be added to xc_error_level_to_desc too */
> };
> 
> 
> 
> 
> I swapped the two declarations and that works just fine :
> 
> enum xc_error_code {
>   XC_ERROR_NONE = 0,
>   XC_INTERNAL_ERROR = 1,
>   XC_INVALID_KERNEL = 2,
>   XC_INVALID_PARAM = 3,
>   XC_OUT_OF_MEMORY = 4,
>   /* new codes need to be added to xc_error_level_to_desc too */
> };
> 
> typedef enum xc_error_code xc_error_code;

That's already been fixed in 4.6:

http://lists.xen.org/archives/html/xen-devel/2014-07/msg00423.html


Cheers,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.