Re: [Xen-devel] [PATCH net v3 2/2] xen-netfront: respect user provided max_queues

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 10/09/15 11:18, Wei Liu wrote:
> Originally that parameter was always reset to num_online_cpus during
> module initialisation, which renders it useless.
> 
> The fix is to only set max_queues to num_online_cpus when user has not
> provided a value.

Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>
Tested-by: David Vrabel <david.vrabel@xxxxxxxxxx>

David

> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -2132,8 +2132,11 @@ static int __init netif_init(void)
>  
>       pr_info("Initialising Xen virtual ethernet driver\n");
>  
> -     /* Allow as many queues as there are CPUs, by default */
> -     xennet_max_queues = num_online_cpus();
> +     /* Allow as many queues as there are CPUs if user has not
> +      * specified a value.
> +      */
> +     if (xennet_max_queues == 0)
> +             xennet_max_queues = num_online_cpus();
>  
>       return xenbus_register_frontend(&netfront_driver);
>  }
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel