Re: [Xen-devel] [PATCH for-4.6] libxl: clear O_NONBLOCK|O_NDELAY on migration fd and reinstate afterwards

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH for-4.6] libxl: clear O_NONBLOCK|O_NDELAY on 
migration fd and reinstate afterwards"):
> The fd passed to us by libvirt for both save and restore has at least
> O_NONBLOCK set, which libxl does not expect and therefore fails to
> handle any EAGAIN which might arise.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> For 4.6: This fixes migration with libvirt, which I think is worth
> doing before the release.

Indeed.

> For backports: Once "ts-xen-install: Rewrite /etc/hosts to comment out
> 127.0.1.1 entry" passes through osstest's pretest gate and has run on
> some of the older branches we should then know if this is necessary
> for migration v1. Or we could backport it regardless.

Let us see what happens.

> +int libxl__fd_flags_modify_save(libxl__gc *gc, int fd,
> +                                int mask, int val, int *r_oldflags)
> +{

This is very ... comprehensive.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel