Re: [Xen-devel] [PATCH v6 00/31] Add ITS support

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Wed, Sep 9, 2015 at 8:59 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> On Mon, 2015-08-31 at 16:36 +0530, vijay.kilari@xxxxxxxxx wrote:
>>  Some Major TODOs:
>>    1) Avoid making vits_process_cmd() static in later point of time
>>    2) How to handle LPI that does not have LPI config table entry.
>>    3) Enable/disable ITS to Dom0
>
> I'm not quite sure what any of these 3 are, can you expand upon them
> please.
>
> Major TODOs I can think of (which may overlap those above which I don't
> understand):
>
>    A. Ensuring that no aspect of the vITS is exposed to domains other than
>       dom0, so no mapping, no GICR registers relating to LPIs or ITS etc.
>    B. A bug fat warning in the code vits_map_translation_space about the
>       issues with exposing this to dom0.
>    C. The issue regarding what to do with physical LPIs which arrive before
>       the guest has mapped the corresponding event in the vits or which is
>       masked
>
> Have I missed anything?
>
> I think A and B are pretty straight forward to fix.
>
> C I think is a bit thornier, and IIRC we do not currently have a plan for
> how we can address this in a generic way. I think we might have some ideas
> which work only for PCI devices (or maybe only PCI-e devices?).
>
> Ian.

I will take care of A & B in next revision.

Is there any further comments on this series?. I have not received
any comments on last few patches (patch #25 to patch#30).

>
>
>>
>> Changes in v5:
>>   - Added following new patches
>>       0001-xen-arm-Return-success-if-dt-node-does-not-have-irq-.patch
>>       0004-xen-arm-Set-nr_cpu_ids-to-available-number-of-cpus.patch
>>       0009-xen-arm-ITS-Export-ITS-info-to-Virtual-ITS.patch
>>       0013-xen-arm-ITS-Implement-gic_is_lpi-helper-function.patch
>>   - Split patch #12 into two patches #14 & #16
>>       0014-xen-arm-ITS-Allocate-irq-descriptors-for-LPIs.patch
>>       0016-xen-arm-ITS-Route-LPIs.patch
>>   - Introduce new API to route LPI (route_lpi_to_guest() )
>>   - Moved patch #8 in v4 as patch #19
>>   - irq_descritors for LPIs are allocated dynamically
>>   - Removed RB-tree for managing vitual its devices. Will be
>>     introduced when pci-passthrough is implemented
>>   - its_add_device() api now takes nr_ites and DT its node as parameters
>>   - some function are kept as non-static when introduced in a patch for
>>     compilation purpose and eventually made static when used.
>>   - Tested compilation for arm32
>>
>> Changes in v4:
>>   - Patch for rate limiting of error message is removed.
>>   - Patch #4 and #5 in v3 is merged
>>   - Merged #13 and #16 as one patch
>>   - hw_irq_controller is implemented for LPIs
>>   - GITS and GICR emulation for LPIs in separate patches
>>   - Removed build functions for ITS command in physical ITS driver
>>   - Added new patch to add and assign devices from platform file
>>   - Enable compilation of vits and pits driver in separate patch
>>   - Replace msi-parent property in all pci dt nodes to single
>>     ITS node generated by Xen for Dom0
>>
>> Vijaya Kumar K (31):
>>   xen/dt: Handle correctly node with interrupt-map in
>>     dt_for_each_irq_map
>>   xen/arm: Add bitmap_find_next_zero_area helper function
>>   xen: Add log2 functionality
>>   xen/arm: Set nr_cpu_ids to available number of cpus
>>   xen/arm: Rename NR_IRQs and vgic_num_irqs helper function
>>   xen/arm: ITS: Port ITS driver to Xen
>>   xen/arm: ITS: Add helper functions to manage its_devices
>>   xen/arm: ITS: Introduce msi_desc for LPIs
>>   xen/arm: ITS: Add APIs to add and assign device
>>   xen/arm: ITS: Introduce gic_is_lpi helper function
>>   xen/arm: ITS: Enable compilation of physical ITS driver
>>   xen/arm: Move vgic locking inside get_irq_priority callback
>>   xen/arm: ITS: implement hw_irq_controller for LPIs
>>   xen/arm: ITS: Initialize physical ITS and export lpi support
>>   xen/arm: ITS: Add virtual ITS driver
>>   xen/arm: ITS: Add virtual ITS commands support
>>   xen/arm: ITS: Store LPIs allocated and IRQ ID bits per domain
>>   xen/arm: ITS: Enable virtual ITS driver
>>   xen/arm: ITS: Export ITS info to Virtual ITS
>>   xen/arm: ITS: Introduce helper to get number of event IDs
>>   xen/arm: ITS: Add GITS registers emulation
>>   xen/arm: ITS: Add virtual ITS availability check helper
>>   xen/arm: ITS: Add 32-bit access to GICR_TYPER
>>   xen/arm: ITS: Add GICR register emulation
>>   xen/arm: ITS: Allocate irq descriptors for LPIs
>>   xen/arm: ITS: Allocate pending_lpi descriptors for LPIs
>>   xen/arm: ITS: Route LPIs
>>   xen/arm: ITS: Add domain specific ITS initialization
>>   xen/arm: ITS: Map ITS translation space
>>   xen/arm: ITS: Generate ITS node for Dom0
>>   xen/arm: ITS: Add pci devices in ThunderX
>>
>>  xen/arch/arm/Makefile             |    2 +
>>  xen/arch/arm/domain_build.c       |   11 +
>>  xen/arch/arm/gic-hip04.c          |   19 +-
>>  xen/arch/arm/gic-v2.c             |   19 +-
>>  xen/arch/arm/gic-v3-its.c         | 1594
>> +++++++++++++++++++++++++++++++++++++
>>  xen/arch/arm/gic-v3.c             |  102 ++-
>>  xen/arch/arm/gic.c                |   73 +-
>>  xen/arch/arm/irq.c                |  176 +++-
>>  xen/arch/arm/platforms/Makefile   |    1 +
>>  xen/arch/arm/platforms/thunderx.c |  151 ++++
>>  xen/arch/arm/setup.c              |    2 +
>>  xen/arch/arm/vgic-v2.c            |    9 +-
>>  xen/arch/arm/vgic-v3-its.c        |  993 +++++++++++++++++++++++
>>  xen/arch/arm/vgic-v3.c            |  419 +++++++++-
>>  xen/arch/arm/vgic.c               |  117 ++-
>>  xen/common/bitmap.c               |   39 +
>>  xen/common/device_tree.c          |    4 +-
>>  xen/include/asm-arm/domain.h      |   11 +
>>  xen/include/asm-arm/gic-its.h     |  387 +++++++++
>>  xen/include/asm-arm/gic.h         |   27 +-
>>  xen/include/asm-arm/gic_v3_defs.h |   51 +-
>>  xen/include/asm-arm/irq.h         |   24 +-
>>  xen/include/asm-arm/vgic.h        |   18 +-
>>  xen/include/xen/bitmap.h          |   16 +
>>  xen/include/xen/lib.h             |    2 +
>>  xen/include/xen/log2.h            |  167 ++++
>>  26 files changed, 4357 insertions(+), 77 deletions(-)
>>  create mode 100644 xen/arch/arm/gic-v3-its.c
>>  create mode 100644 xen/arch/arm/platforms/thunderx.c
>>  create mode 100644 xen/arch/arm/vgic-v3-its.c
>>  create mode 100644 xen/include/asm-arm/gic-its.h
>>  create mode 100644 xen/include/xen/log2.h
>>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel