Re: [Xen-devel] [PATCH] KVM: arm64: add workaround for Cortex-A57 erratum #852523

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-09-15 at 00:08 +0100, Julien Grall wrote:
> On 14/09/2015 16:58, Will Deacon wrote:
> > > The Xen ctxt switch code[0] has DACR_EL2 in the midst of it all, and
> > > certainly followed by some sysregs, which I've got my fingers crossed
> > > happens to be sufficient (other than maybe adding a comment).
> > 
> > It looks like you restore CONTEXTIDR_EL1 fairly late, so you should be
> > ok.

Thanks Will.

> It may be worth to have a comment in the code explaining the errata to 
> avoid introduce by inadvertence if we plan to re-order the context
> switch.
> 
> I can send a patch for that.

Yes, please, a comment right before we restore DACR32_EL2 with the list of
register Will gave would be best I think.

> 
> Regards,
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel