Re: [Xen-devel] [PATCH 1/2] xen/arm: gic-v3: Clean-up the GIC*_PIDR2_* definitions

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-09-14 at 16:32 +0100, Julien Grall wrote:
> GICR_PIDR2 and GICD_PIDR2 use the same register layout. Rather than
> define twice, one of which is an alias to the other, introduce
> GIC_PIDR2_*
> defines.
> 
> Also:
>     * Use the same prefix for the mask and the value
>     * Integrate the shift in the value to avoid shifting in the code
>     * Use GICv* to match the value name in the spec
>     * Move them in a proper place
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel