[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] libxl: slightly refine pci-assignable-{add, remove} handling
On Tue, 2015-09-15 at 10:31 +0100, Ian Campbell wrote: > On Mon, 2015-09-14 at 10:50 +0100, George Dunlap wrote: > > On Thu, Sep 10, 2015 at 1:36 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote: > > > While it appears to be intentional for "xl pci-assignable-remove" to > > > not re-bind the original driver by default (requires the -r option), > > > permanently losing the information which driver was originally used > > > seems bad. Make "add; remove; add; remove -r" re-bind the original > > > driver by allowing "remove" to delete the information only upon > > > successful re-bind. > > > > I would be open to the argument that I was being overly paranoid in > > making "xl pci-assignable-remove" not re-bind by default. But either > > way: > > > > Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx> > > The use of "rc" to hold a non-libxl error code (0 or -1 in this case) in > _add is not allowed by libxl coding style, but is consistent with the > same > thing existing in _remove, also this code is mostly in hypervisor coding > style so it seems tolerable for this new code to be so too. > > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> and applied. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |