Re: [Xen-devel] [OSSTEST PATCH 17/27] mg-show-flight-runvars: Decorate synth runvar names with ~

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST PATCH 17/27] mg-show-flight-runvars: 
Decorate synth runvar names with ~"):
> On Wed, 2015-09-16 at 14:35 +0100, Ian Jackson wrote:
> > Make mg-show-flight-runvars -a append ~ to the names of synth runvars.
> > (This is consistent with the new syntax in cs-job-create.)
> > 
> > We do this by editing $row->[1] (and $colws[1]) so we can avoid
> > disturbing the general column format calcuation and printing; this
> 
> "calculation"

Fixed.

> > means we have to copy $row (because the value in the DB $row is
> > readonly).
> 
> fetchrow_array instead of fetchrow_arrayref would avoid the copy, at the
> expense of removing -> from the usages (or taking the ref yourself).

Yes.  I have done that and it's nicer.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel