Re: [Xen-devel] [PATCH v2] MAINTAINERS: Document maintainers for xen/common/

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 17/09/15 12:59, Andrew Cooper wrote:
> On 17/09/15 12:53, Ian Jackson wrote:
>> This is a copy of the `THE REST' entry but with my own entry removed
>> (as I do not normally review hypervisor patches) and Andrew Cooper's
>> added (which seems appropriate given his status as x86 hypervisor
>> maintainer).
>>
>> The effect is that patches touching xen/common/ will no longer be CC'd
>> to me; but also that Ian C, Andrew, Jan, Keir and Tim will get _all_
>> patches touching xen/common/, not just ones which match one of their
>> existing more specific entries.
>>
>> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
>> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> CC: Jan Beulich <jbeulich@xxxxxxxx>
>> CC: Keir Fraser <keir@xxxxxxx>
>> CC: Tim Deegan <tim@xxxxxxx>
>> CC: Julien Grall <julien.grall@xxxxxxxxxx>
>> CC: David Vrabel <david.vrabel@xxxxxxxxxx>
>> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>
>> ---
>> v2: A completely different approach following discussion with Ian C.
>> ---
>>  MAINTAINERS |   10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index a6bece6..e35c1e9 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -404,6 +404,16 @@ F:  xen/include/xsm/
>>  F:  xen/xsm/
>>  F:  docs/misc/xsm-flask.txt
>>  
>> +HYPERVISOR CORE
>> +M:  Jan Beulich <jbeulich@xxxxxxxx>
>> +M:  Tim Deegan <tim@xxxxxxx>
>> +M:  Keir Fraser <keir@xxxxxxx>
>> +M:  Ian Campbell <ian.campbell@xxxxxxxxxx>
>> +M:  Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> +L:  xen-devel@xxxxxxxxxxxxx
>> +S:  Supported
>> +F:  xen/common/
> 
> I am happy with the change in principle, but it should cover xen/ rather
> than xen/common/ to also include otherwise unqualified items in
> xen/drivers/.

The first version of this patch was covering xen/. But the downside was
to CC all the "REST OF THE HYPERVISOR" group to any changes under xen/.
I.e you would be CCed on ARM changes for instance.

See http://lists.xen.org/archives/html/xen-devel/2015-09/msg02171.html

I know some maintainers which will complaining very quickly on the ML
and ask the contributors to use correctly scripts/get_maintainers.pl.

But the scrips doesn't do correctly his job for Xen...

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel