Re: [Xen-devel] [PATCH 0/3] x86/paravirt: Fix baremetal paravirt MSR ops

[Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>]

> > ( We should double check that rdmsr()/wrmsr() results are never left
> >    uninitialized, but are set to zero or so, for cases where the return code is 
> > not
> >    checked. )
> It sure looks like native_read_msr_safe doesn't clear the output if
> the rdmsr fails.
I'd suggest to return some poison not just 0...
less likely to get interesting surprises that are insane hard to debug/diagnose




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel