Re: [Xen-devel] xen/arm: gicv3: Computation of GICD_TYPER.IDbits

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-09-18 at 12:56 +0530, Vijay Kilari wrote:
> Hi Julien,
> 
>  static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info)
>  {
>      ...
>            case GICD_TYPER:
>            {
>                /*
>                 * Number of interrupt identifier bits supported by the
> GIC
>                 * Stream Protocol Interface
>                 */
>                unsigned int irq_bits =
> get_count_order(vgic_num_irqs(v->domain));
> }
> 
> I think we should use ilog2() instead of get_count_order()?

Please explain why.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel