[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] xen: Introduce VM_EVENT_FLAG_SET_EIP



>>> On 18.09.15 at 21:19, <tamas@xxxxxxxxxxxxx> wrote:
> On Wed, Sep 16, 2015 at 12:12 PM, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx 
>> wrote:
>> I have nothing in principle against having a SET_REGISTERS flag instead
>> of a SET_EIP one, but I am unsure of how (and where) that would be best
>> implemented. What do you have in mind? A handler similar to void
>> vm_event_register_write_resume() where we set these registers for the
>> respective vcpu? Is this even possible at vm_event response handling time?
>>
> 
> No, that function falls under a switch on rsp.reason, for which we have a
> 1:1 unofficial and not really enforced rule to match the type of event that
> was sent. This should fall under a flag on rsp.flags and be handled similar
> to how vm_event_toggle_singlestep is.

I.e. I take this to mean that we should wait for a new patch
rather than further looking at the current one.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.