[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 05/28] xen/arm: ITS: Port ITS driver to Xen



On 18/09/15 14:08, vijay.kilari@xxxxxxxxx wrote:
> +static void its_lpi_free(struct its_device *dev)
> +{
> +    int lpi;
> +
> +    spin_lock(&lpi_lock);
> +
> +    for ( lpi = dev->event_map.lpi_base;
> +          lpi < (dev->event_map.lpi_base + dev->event_map.nr_lpis);
> +          lpi += IRQS_PER_CHUNK )
> +    {
> +        int chunk = its_lpi_to_chunk(lpi);
> +
> +        if (chunk > lpi_chunks)
> +            its_err("Bad LPI chunk %d\n", chunk);
> +        if ( test_bit(chunk, lpi_bitmap) )
> +            clear_bit(chunk, lpi_bitmap);
> +    }
> +
> +    spin_unlock(&lpi_lock);
> +
> +    xfree(dev->event_map.lpi_map);

You didn't import correctly the patch which support collection for
Linux. It misses:

      xfree(dev->event_map.col_map);

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.