Re: [Xen-devel] [PATCH v7 13/28] xen/arm: Move vgic rank locking inside get_irq_priority

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 18/09/15 14:09, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> Move vgic rank locking inside get_irq_priority callback.
> LPIs does not have vgic rank lock for reading LPI priority.
> So make generic vgic code cleaner.

The commit message is not clear. I would rewrite like that:

"The LPIs will require a different locking scheme to retrieve the priority.
So move the vGIC rank locking inside the callback get_irq_priority."

> 
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>

Assuming that the suggested commit message is fine for you:

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel