Re: [Xen-devel] [PATCH v6 2/2] xen/arm: support gzip compressed kernels

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Stefano,

On 22/09/2015 02:35, Stefano Stabellini wrote:
> > > You may want to use vmap here which is a wrapper to __vmap and will setup the
> > > granularity, align, and flags automatically for you.
> > The arguments are different.
Yes, sorry I inverted nr with granularity.

> I meant to say that it makes more sense to pass one region of higher 
> granularity,
> than to map pages one by one.
Well, the page will still be mapped one by one in map_pages_to_xen one 
by one because we don't support super-page mapping.
TBH if you care about performance, you would only map the strict 
necessary because the smallest granularity to fit all the kernel may be 
big compare to the real size.
For instance, if the decompress size is 65M, you would have to map 128M.

Anyway, it's only used during boot, so I don't much care if you use 
__vmap. My suggestion was only for simplifying the code.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel