Re: [Xen-devel] [PATCH v7 10/17] vt-d: Extend struct iremap_entry to support VT-d Posted-Interrupts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.09.15 at 10:28, <feng.wu@xxxxxxxxx> wrote:
> Extend struct iremap_entry according to VT-d Posted-Interrupts Spec.
> 
> CC: Yang Zhang <yang.z.zhang@xxxxxxxxx>
> CC: Kevin Tian <kevin.tian@xxxxxxxxx>
> Signed-off-by: Feng Wu <feng.wu@xxxxxxxxx>
> Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> ---
> v7:
> - Add a __uint128_t member to the union in struct iremap_entry

How about making use of this e.g. ...

> @@ -219,7 +219,7 @@ static unsigned int alloc_remap_entry(struct iommu 
> *iommu, unsigned int nr)
>          else
>              p = &iremap_entries[i % (1 << IREMAP_ENTRY_ORDER)];
>  
> -        if ( p->lo_val || p->hi_val ) /* not a free entry */
> +        if ( p->lo || p->hi ) /* not a free entry */

... here and ...

> @@ -253,7 +253,7 @@ static int remap_entry_to_ioapic_rte(
>      GET_IREMAP_ENTRY(ir_ctrl->iremap_maddr, index,
>                       iremap_entries, iremap_entry);
>  
> -    if ( iremap_entry->hi_val == 0 && iremap_entry->lo_val == 0 )
> +    if ( iremap_entry->hi == 0 && iremap_entry->lo == 0 )

... here (and perhaps elsewhere)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel