Re: [Xen-devel] [PATCH] x86/boot: Move/copy sections more efficiently

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.09.15 at 10:14, <andrew.cooper3@xxxxxxxxxx> wrote:
> The ALIGN(STACK_SIZE) actually belongs with .bss.stack_aligned, but
> __init_end still needs page alignment because of the init sections being
> freed and returned to the domheap after boot.

Logically that change makes sense, but ...

> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -158,11 +158,13 @@ SECTIONS
>         __xsm_initcall_start = .;
>         *(.xsm_initcall.init)
>         __xsm_initcall_end = .;
> +
> +       . = ALIGN(PAGE_SIZE);
>    } :text
> -  . = ALIGN(STACK_SIZE);
>    __init_end = .;
>  
>    .bss : {                     /* BSS */
> +       . = ALIGN(STACK_SIZE);
>         __bss_start = .;
>         *(.bss.stack_aligned)
>         . = ALIGN(PAGE_SIZE);

... any pages between __init_end and __bss_start will all of the
sudden no longer get freed. I.e. you'll want to move __init_end
as well (which belongs inside some section anyway).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel