Re: [Xen-devel] [PATCH v2] xen/keyhandler: Rework keyhandler infrastructure

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

> > +void register_irq_keyhandler(unsigned char key,
> > +                             irq_keyhandler_fn_t *fn,
> > +                             const char *desc,
> > +                             bool_t diagnostic);
> I wonder whether the last parameter is really useful here.
Yes.  There are diagnostic irq_keyhandlers, 'd' for example.

All callers in practice will be __init, so overhead is not interesting, 
and it should be present for completeness.
~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel