Re: [Xen-devel] [PATCH v7 23/28] xen/arm: ITS: Allocate pending_lpi descriptors for LPIs

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 18/09/15 14:09, vijay.kilari@xxxxxxxxx wrote:
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index 6a5c6a0..49630a3 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -101,6 +101,9 @@ struct arch_domain
>           * struct arch_vcpu.
>           */
>          struct pending_irq *pending_irqs;
> +#ifdef HAS_GICV3
> +        struct pending_irq *pending_lpis;
> +#endif

It's rather strange to expose nr_lpis, vgic_is_domain_lpi to anyone but
not pending_lpis.

Please either expose to anyone anything related to LPIs or nothing. But
not only some of them for convenience in the code.

As for physical LPIs I would much prefer to see this code compiled for
everyone.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel