[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 24/29] xen/x86: allow HVM guests to use hypercalls to bring up vCPUs



>>> On 25.09.15 at 17:16, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 21/09/15 16:44, Jan Beulich wrote:
>>> +    uint32_t cr0;
>>> +    uint32_t cr3;
>>> +    uint32_t cr4;
>>> +    uint64_t efer;
>> What again was the point of having EFER here?
> 
> EFER.NX must match what the BSP chose to set up in the pagetables 
> pointed to in %cr3, or a triple fault will occur.

That is assuming the AP is to start up on shared page tables, which
is not a given. Hence a comment seems warranted to state that this
is there to allow such a usage by the guest.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.