Re: [Xen-devel] [PATCH V3 2/2] xen: Introduce VM_EVENT_FLAG_SET_REGISTERS

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/09/15 11:16, Razvan Cojocaru wrote:
> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
> index ff2f217..3e4efad 100644
> --- a/xen/include/public/vm_event.h
> +++ b/xen/include/public/vm_event.h
> @@ -89,6 +89,12 @@
>   * by the altp2m_idx response field if possible.
>   */
>  #define VM_EVENT_FLAG_ALTERNATE_P2M      (1 << 7)
> +/*
> + * Set the vCPU registers to the values in the  vm_event response.
> + * Applies to EAX-EDX, ESP, EBP, ESI, EDI, R8-R15, EFLAGS, and EIP.
> + * Requires the vCPU to be paused already (synchronous events only).
> + */

The set registers are architecture specific, or will be if/when ARM
gains support.

It is fine to list the architecture specific bits here (as there are no
more appropriate places for it to live) but do explicitly call out that
the 2nd sentence in x86 specific.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel