Re: [Xen-devel] [PATCH v6 22/29] elfnotes: intorduce a new PHYS_ENTRY elfnote

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.09.15 at 12:35, <roger.pau@xxxxxxxxxx> wrote:
> El 21/09/15 a les 16.47, Jan Beulich ha escrit:
>>>>> On 04.09.15 at 14:09, <roger.pau@xxxxxxxxxx> wrote:
>>> --- a/xen/include/public/elfnote.h
>>> +++ b/xen/include/public/elfnote.h
>>> @@ -200,9 +200,18 @@
>>>  #define XEN_ELFNOTE_SUPPORTED_FEATURES 17
>>>  
>>>  /*
>>> + * Physical entry point into the kernel.
>>> + *
>>> + * 32bit entry point into the kernel. Xen will use this entry point
>>> + * in order to launch the guest kernel in 32bit protected mode
>>> + * with paging disabled.
>>> + */
>>> +#define XEN_ELFNOTE_PHYS32_ENTRY 18
>> 
>> The comment reads as if this was the case for all kinds of guests,
>> yet I suppose it doesn't apply to PV ones. This should be made
>> explicit if so.
> 
> Yes, what about the following:
> 
> 32bit entry point into the kernel. Xen will use this entry point
> in order to launch the guest kernel in 32bit protected mode with paging
> disabled inside of an HVM container.

Depends: If the note's presence means this and only this entry point
will be used, then okay. If, however, normal PV and/or HVM operation
of such a guest is still intended to be possible, then I think this is still
too vague. Perhaps

32bit entry point into the kernel. When requested to launch the
guest kernel in a HVM container, Xen will use this entry point to
launch the guest in 32bit protected mode with paging disabled.
Ignored otherwise.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel