Re: [Xen-devel] [PATCH 1/8] xen/arm: gic: Make clear the GIC node is passed to make_hwdom_dt_node

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 25/09/15 16:48, Ian Campbell wrote:
> On Tue, 2015-09-22 at 18:47 +0100, Julien Grall wrote:
> 
> "Make it clear..." in the subject.
> 
>> The callback make_hwdom_dt_node already have the gic node in parameter.
> 
> "...already has the..." or "...already takes the..."
> 
>> Rather than using a weird mix between "dt_interrupt_controller" (aliased
>> to "gic") and "node", rename the callback parameter "node" to "gic".
> 
> "... and remove local gic definitions in terms of the global
> dt_interrupt_controller".
> 
> Also given the hunk below I'd recommend adding:
> "Add an assert to gic_make_hwdom_dt_node to check that the gic really is
> the global dt_interrupt_controller"

Your suggestions looks good. Although, I replaced gic by GIC because
it's an acronym.

>> @@ -702,10 +702,12 @@ void __cpuinit init_maintenance_interrupt(void)
>>  }
>>  
>>  int gic_make_hwdom_dt_node(const struct domain *d,
>> -                           const struct dt_device_node *node,
>> +                           const struct dt_device_node *gic,
>>                             void *fdt)
>>  {
>> -    return gic_hw_ops->make_hwdom_dt_node(d, node, fdt);
>> +    ASSERT(gic == dt_interrupt_controller);
>> +
>> +    return gic_hw_ops->make_hwdom_dt_node(d, gic, fdt);
>>  }
> 
> With those commit message changes:
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thank you!


Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel