Re: [Xen-devel] [PATCH for Xen 4.6 0/5] Several PSR fixes in libxl

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Mon, 2015-09-28 at 15:16 +0100, Wei Liu wrote:
> On Mon, Sep 28, 2015 at 07:54:48PM +0800, Chao Peng wrote:
> > The patch basically contains several PSR fixes in libxl.
> > patch1-3: fix the socket display error in certain hotplug case.
> > patch4:   fix a minor range check.
> > patch5:   improve the PSR document.
> > 
> > Detailed problem and fix please see commit message.
> > 
> 
> I've gone through all patches. This series looks sensible to me. And
> I
> see the point of getting in it for 4.6 to avoid releasing APIs that
> are
> deemed buggy.
> 
FWIW, I totally agree.

The patch looks sensible to me too, I've only found a couple of minor
issues.

> I would still like some more proof reading from someone who have
> played
> with this feature. I've CCed Dario and Meng.
> 
Thanks for pinging... I've done my best. :-)

About the suggestions I provided, the more important thing, IMO, is the
name of the new function for retrieving the available sockets bitmap,
which I really think it should be called libxl_get_online_socketmap(). 

The others are indeed minor things, which don't affect public APIs and
hence --although I'd prefer to see them addressed-- we can fix/change
them post 4.6 too.

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel