Re: [Xen-devel] [Patch RFC 01/13] vt-d: Redefine iommu_set_interrupt() for registering MSI interrupt

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.09.15 at 15:23, <quan.xu@xxxxxxxxx> wrote:
> Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>

The title isn't really meaningful, and there's no description.

> @@ -1084,8 +1086,8 @@ static int __init iommu_set_interrupt(struct 
> acpi_drhd_unit *drhd)
>      }
>  
>      desc = irq_to_desc(irq);
> -    desc->handler = &dma_msi_type;
> -    ret = request_irq(irq, 0, iommu_page_fault, "dmar", iommu);
> +    desc->handler = irq_ctrl;

I suppose (also taking the title into account) any the planned second
user will also use dma_msi_type, so there's no real point in making
this a function parameter.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel