Re: [Xen-devel] [PATCH 3/4 RFC] x86/p2m: use large pages for MMIO mappings

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.09.15 at 14:52, <julien.grall@xxxxxxxxxx> wrote:
> On 29/09/15 13:46, Jan Beulich wrote:
>> Again, make map_mmio_regions() a wrapper around an ARM-specific
>> function with the extra argument. No need to alter common or x86
>> code.
> 
> TBH, extending the mapp_mmio_region is the best solution.
> 
> The name map_mmio_region is very generic and there is no reason we can't
> use it in the hypervisor. Adding yet another wrapper will confuse people
> and it will be hard for both the reviewer and the developer to know
> which one to use.

I disagree - the function was originally meant to exclusively support
the respective domctl. The fact that ARM gained (many) more uses
should not impact common code or x86.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel